NAS-130700 / 25.04 / Add support for remote controller audit query and download #14483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Valid 'controller' values are 'MASTER','Active','BACKUP','Standby'. The default is the 'current' controller. Add retries with delay on remote DB call in CI test. Enhance the CI test asserts.
Still in debug.
Create common helper function. Complete download CI test.
bugclerk
changed the title
anodos325
reviewed
Sep 10, 2024
yocalebo
requested changes
Sep 11, 2024
Improve failure handling on the 'remote_call'. Remove changes to audit/utils.py Update CI tests.
yocalebo
reviewed
Sep 11, 2024
yocalebo
approved these changes
Sep 11, 2024
|
This PR has been merged and conversations have been locked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
On HA systems each controller maintains an independent audit database. Actions on a controller are reported only in the audit DB associated with that controller.
Solution
Provide the capability to query and download the audit DB from the 'other' controller.
If no controller is specified the audit action is performed on the 'current' controller.
If the controller is specified the audit action will be performed on the requested controller.
The controller can be specified by any of the following names: 'BACKUP', 'Standby', 'MASTER', 'Active'.
Passing CI tests: http://jenkins.eng.ixsystems.net:8080/job/tests/job/api_tests/631/